Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cgd 36 #5

Merged
merged 23 commits into from
Sep 5, 2023
Merged

Feature/cgd 36 #5

merged 23 commits into from
Sep 5, 2023

Conversation

timothyrusso
Copy link
Contributor

@timothyrusso timothyrusso commented Aug 26, 2023

Description and impacts

  • Add the new Tech Stack component.
  • Add primary colors configuration.
  • Basic responsive layout.

Jira related story

CGD-36

Screenshots

image

How to test it

Add the <TechStackContainer /> component to the ./chingu-dashboard/src/app/page.tsx

@vercel
Copy link

vercel bot commented Aug 26, 2023

Someone is attempting to deploy this pull request to the Chingu Dashboard Team on Vercel.

To accomplish this, the commit author's email address needs to be associated with a GitHub account.

Learn more about how to change the commit author information.

@timothyrusso timothyrusso deleted the feature/CGD-36 branch August 26, 2023 13:42
@timothyrusso timothyrusso restored the feature/CGD-36 branch August 26, 2023 13:44
@timothyrusso timothyrusso reopened this Aug 26, 2023
@timothyrusso timothyrusso deleted the feature/CGD-36 branch August 26, 2023 13:45
@timothyrusso timothyrusso restored the feature/CGD-36 branch August 26, 2023 13:56
@timothyrusso timothyrusso reopened this Aug 26, 2023
@vercel
Copy link

vercel bot commented Aug 28, 2023

@timothyrusso is attempting to deploy a commit to the Chingu Dashboard Team on Vercel.

To accomplish this, @timothyrusso needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

@github-actions
Copy link

github-actions bot commented Aug 28, 2023

Copy link
Contributor

@Dan-Y-Ko Dan-Y-Ko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the comments I left, this looks good. Just one thing though. Can you add the page for this and put the component in that page itself. As a reminder, the techstack folder should contain an index.ts file (for the barrel exports), a page.tsx file, and then the components folder. The contents of the components folder will be same as what you have currently.

Once this is updated, I'll test it locally before merging :)

tailwind.config.js Outdated Show resolved Hide resolved
tailwind.config.js Outdated Show resolved Hide resolved
@timothyrusso
Copy link
Contributor Author

timothyrusso commented Aug 29, 2023

Other than the comments I left, this looks good. Just one thing though. Can you add the page for this and put the component in that page itself. As a reminder, the techstack folder should contain an index.ts file (for the barrel exports), a page.tsx file, and then the components folder. The contents of the components folder will be same as what you have currently.

Once this is updated, I'll test it locally before merging :)

@Dan-Y-Ko Done, let me know if this is what you are expecting :)

@vercel
Copy link

vercel bot commented Sep 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chingu-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2023 7:07am

@Dan-Y-Ko
Copy link
Contributor

Dan-Y-Ko commented Sep 1, 2023

Ok, I cloned it locally, it looks good. Just a few more things to change.

  1. Let's go with kebab case for the folder names if contains multiple words like in this situation (so rename it to tech-stack).
  2. In tech-stack/index (so outside the components folder), change the file to this
export { default as TeckStackPage } from "./page";
  1. In the tech-stack/page.tsx file, rename the component to TechStackPage.
  2. In the root index.ts file (in the app folder), change the file to this
export { CounterPage } from "./counter/";
export { TeckStackPage } from "./tech-stack/";

You can remove what's in there currently, the import for the counter I had there initially is incorrect so might as well edit it to avoid confusion for the others.

Hopefully, I covered everything so we can close this pr lol

@Dan-Y-Ko Done! Let me know if I must correct something else :)

@Dan-Y-Ko
Copy link
Contributor

Dan-Y-Ko commented Sep 5, 2023

As the theming is finalized now, can you update the colors to follow the theming set in Figma (the theme has been merged into the dev branch).

@timothyrusso
Copy link
Contributor Author

As the theming is finalized now, can you update the colors to follow the theming set in Figma (the theme has been merged into the dev branch).

@Dan-Y-Ko I've updated the colors, but we are missing the color for the Avatar component: #D9D9D9;

@Dan-Y-Ko
Copy link
Contributor

Dan-Y-Ko commented Sep 5, 2023

As the theming is finalized now, can you update the colors to follow the theming set in Figma (the theme has been merged into the dev branch).

@Dan-Y-Ko I've updated the colors, but we are missing the color for the Avatar component: #D9D9D9;

No, that is not part of the theme. You can see the colors in the figma here: https://www.figma.com/file/OAKUcYBLP3UOaRlnKrcf1G/Chingu-Dashboard?node-id=2743%3A14568&mode=dev

The figma may not be 100% updated to reflect the theme colors yet. In this case though, it's fine because the avatar component won't really have a color, it should just be an image (in the final product).

@Dan-Y-Ko
Copy link
Contributor

Dan-Y-Ko commented Sep 5, 2023

Everything looks good to me now!

@Dan-Y-Ko Dan-Y-Ko merged commit 790a7fd into dev Sep 5, 2023
@Dan-Y-Ko Dan-Y-Ko deleted the feature/CGD-36 branch September 5, 2023 19:27
Dan-Y-Ko added a commit that referenced this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants